Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated filter after_set_parsely_page #436

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Remove deprecated filter after_set_parsely_page #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f074d6
Remove deprecated filter after_set_parsely_page
pauarge Oct 6, 2021
52e3469
Updating tests
pauarge Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions src/class-parsely.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,23 +1055,6 @@ public function construct_parsely_metadata( array $parsely_options, $post ): arr
$parsely_page['url'] = home_url();
}

/**
* Filters the structured metadata.
*
* @deprecated 2.5.0 Use `wp_parsely_metadata` filter instead.
* @since 1.10.0
*
* @param array $parsely_page Existing structured metadata for a page.
* @param WP_Post $post Post object.
* @param array $parsely_options The Parsely options.
*/
$parsely_page = apply_filters_deprecated(
'after_set_parsely_page',
array( $parsely_page, $post, $parsely_options ),
'2.5.0',
'wp_parsely_metadata'
);

/**
* Filters the structured metadata.
*
Expand Down
3 changes: 1 addition & 2 deletions tests/Integration/OtherTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ public function test_load_js_api_with_secret(): void {
/**
* Check out page filtering.
*
* @expectedDeprecated after_set_parsely_page
* @covers \Parsely::construct_parsely_metadata
* @uses \Parsely::get_author_name
* @uses \Parsely::get_author_names
Expand Down Expand Up @@ -282,7 +281,7 @@ public function test_parsely_page_filter(): void {
// Apply page filtering.
$headline = 'Completely New And Original Filtered Headline';
add_filter(
'after_set_parsely_page',
'wp_parsely_metadata',
function( $args ) use ( $headline ) {
$args['headline'] = $headline;

Expand Down