Skip to content

Commit

Permalink
Deepintent: Params normalization (prebid#1617)
Browse files Browse the repository at this point in the history
Co-authored-by: Sourabh Gandhe <sourabh@Sourabhs-MacBook-Pro.local>
  • Loading branch information
2 people authored and shunj-nb committed Nov 8, 2022
1 parent 8777868 commit b8d690f
Show file tree
Hide file tree
Showing 15 changed files with 22 additions and 22 deletions.
2 changes: 1 addition & 1 deletion adapters/deepintent/deepintent.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type DeepintentAdapter struct {
}

type deepintentParams struct {
TagID string `json:"tagId"`
tagId string `json:"tagId"`
}

// Builder builds a new instance of the Deepintent adapter for the given bidder with the given config.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "16"
"tagId": "16"
}
}
}
Expand Down Expand Up @@ -64,7 +64,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "16"
"tagId": "16"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "1"
"tagId": "1"
}
}
}
Expand Down Expand Up @@ -63,7 +63,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "1"
"tagId": "1"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/deepintent/deepintenttest/params/banner.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"TagID": "16"
"tagId": "16"
}
2 changes: 1 addition & 1 deletion adapters/deepintent/deepintenttest/params/race/banner.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"TagID": "16"
"tagId": "16"
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "17"
"tagId": "17"
}
}
}
Expand Down Expand Up @@ -62,7 +62,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "17"
"tagId": "17"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"id": "test-banner-imp-id",
"ext": {
"bidder": {
"TagId": "16"
"tagId": "16"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"ext": {
"bidder": {
"TagId":"16"
"tagId":"16"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "17"
"tagId": "17"
}
}
}
Expand Down Expand Up @@ -62,7 +62,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "17"
"tagId": "17"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "100000000"
"tagId": "100000000"
}
}
}
Expand Down Expand Up @@ -62,7 +62,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "100000000"
"tagId": "100000000"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"tagid": "16",
"ext": {
"deepintent": {
"TagID": "16"
"tagId": "16"
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions adapters/deepintent/deepintenttest/supplemental/wrongimp.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "16"
"tagId": "16"
}
}
}
Expand Down Expand Up @@ -64,7 +64,7 @@
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"TagID": "16"
"tagId": "16"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/deepintent/params_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func TestInvalidParams(t *testing.T) {
}

var validParams = []string{
`{"TagID": "16"}`,
`{"tagId": "16"}`,
}

var invalidParams = []string{
Expand Down
2 changes: 1 addition & 1 deletion static/bidder-info/deepintent.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
maintainer:
email: "sourabh@deepintent.com"
email: "prebiddev@deepintent.com"
capabilities:
app:
mediaTypes:
Expand Down
4 changes: 2 additions & 2 deletions static/bidder-params/deepintent.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@

"type": "object",
"properties": {
"TagID": {
"tagId": {
"type": "string",
"description": "An ID which identifies the deepintent ad tag"
}
},
"required" : [ "TagID" ]
"required" : [ "tagId" ]
}

0 comments on commit b8d690f

Please sign in to comment.