Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft inversion for Neo.java #56

Closed
GalexY727 opened this issue Jan 24, 2024 · 2 comments · Fixed by #62
Closed

Soft inversion for Neo.java #56

GalexY727 opened this issue Jan 24, 2024 · 2 comments · Fixed by #62
Assignees
Labels
good first issue Good for newcomers invalid This doesn't seem right logic A logic problem or solution

Comments

@GalexY727
Copy link
Member

Rather than having a parameter inside of Neo's constructor to call motor.setInverted, we should rather have it set a global variable (-1 multiplier) that gets applied to every input going to the motor. For example, We want a motor to be inverted and go 100% speed. if the "soft inversion" is true, then it would multiply our desired speed and multiply it by -1, which would effectively invert it and give us the same effect we would have gotten if we inverted the motor. I am still freaked out about the qual at chezy champs where jerome's claw didn't invert after telling it to, so this would be an alternate solution to hope that this doesn't have the opportunity to happen again.

@GalexY727 GalexY727 added good first issue Good for newcomers invalid This doesn't seem right logic A logic problem or solution labels Jan 24, 2024
@GalexY727 GalexY727 self-assigned this Jan 24, 2024
@GalexY727 GalexY727 moved this to Ready in Crescendo 2024 Jan 24, 2024
@GalexY727 GalexY727 removed the status in Crescendo 2024 Jan 24, 2024
@GalexY727 GalexY727 moved this to Ready in Crescendo 2024 Jan 24, 2024
@Jacob1010-h
Copy link
Member

ooooo
can i try this?

@GalexY727
Copy link
Member Author

have at it!

@Jacob1010-h Jacob1010-h assigned Jacob1010-h and unassigned GalexY727 Jan 24, 2024
@Jacob1010-h Jacob1010-h moved this from Ready to In progress in Crescendo 2024 Jan 24, 2024
@Jacob1010-h Jacob1010-h linked a pull request Jan 24, 2024 that will close this issue
@Jacob1010-h Jacob1010-h moved this from In progress to In review in Crescendo 2024 Jan 25, 2024
Jacob1010-h added a commit that referenced this issue Jan 25, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Crescendo 2024 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers invalid This doesn't seem right logic A logic problem or solution
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants