Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Led control using pwm #108

Merged
merged 24 commits into from
Feb 2, 2024
Merged

Led control using pwm #108

merged 24 commits into from
Feb 2, 2024

Conversation

derp00monsta
Copy link
Contributor

Hopefully this is shrimply good enough for a pr now. The LPI command has been made and has yet to be inegrated. An LedStrip class was also made.

derp00monsta and others added 21 commits January 24, 2024 17:17
@derp00monsta @HHQB
@BredPerson @GalexY727 @PatribotsProgramming
add a rainbow method and start structure for greenngold bounce
6bcacc9 
Co-authored-by: AidenM <HHQB@users.noreply.github.com>
Co-authored-by: BredPerson <BredPerson@users.noreply.github.com>
Co-authored-by: Alexander Hamilton <a.hamilton72006@gmail.com>
Co-authored-by: ChadPad <PatribotsProgramming@users.noreply.github.com>
@PatribotsProgramming @GalexY727
Make the greenNGold actually shift left and right, and add a desmos l…
5a95c22 
…ink to visualize it.

Co-authored-by: Alexander Hamilton <a.hamilton72006@gmail.com>
@derp00monsta
update vendor deps
18b7672
@derp00monsta
make leds turn green n gold when robot turns on
d190b6e
@TotalMoron
Co-authored-by: Tina H <derp00monsta@users.noreply.github.com>
fb07566
@BredPerson
eeeeeeeeeeeeeeeeeeeee
2fa9131
@BredPerson
Co-authored-by: ChadPad <PatribotsProgramming@users.noreply.github.com>
8a7a078 
Co-authored-by: Hadizah454 <Hadizah454@users.noreply.github.com>
Co-authored-by: Tina H <derp00monsta@users.noreply.github.com>
Co-authored-by: rin-star <rin-star@users.noreply.github.com>
@PatribotsProgramming @rin-star
@BredPerson @derp00monsta
Add a couple of LED functions and start the process of converting the…
424a06b 
… hashmap to have values of Commands rather than strings

Co-authored-by: rin-star <rin-star@users.noreply.github.com>
Co-authored-by: BredPerson <BredPerson@users.noreply.github.com>
Co-authored-by: Tina H <derp00monsta@users.noreply.github.com>
@PatribotsProgramming
move patternMap to constants
89f8bae 
needs rename!
@derp00monsta @rin-star
@Hadizah454 @BredPerson @frighthunt
Led Control Using PWM
146258a 
Fixes #13

make buttons & alter the logic for the LPI

Co-authored-by: rin-star <rin-star@users.noreply.github.com>
Co-authored-by: Hadizah454 <Hadizah454@users.noreply.github.com>
Co-authored-by: BredPerson <BredPerson@users.noreply.github.com>
Co-authored-by: frighthunt <frighthunt@users.noreply.github.com>
@derp00monsta @rin-star
@Hadizah454 @BredPerson @frighthunt @TyGagielo
add zone constants & make leds change depending on the zone
9acc757 
Co-authored-by: rin-star <rin-star@users.noreply.github.com>
Co-authored-by: Hadizah454 <Hadizah454@users.noreply.github.com>
Co-authored-by: BredPerson <BredPerson@users.noreply.github.com>
Co-authored-by: frighthunt <frighthunt@users.noreply.github.com>
Co-authored-by: TyGagielo <TyGagielo@users.noreply.github.com>
@Jacob1010-h
#80
2ce019a
@Jacob1010-h
Merge branch 'led-control-using-pwm' of https://github.com/Patribots4…
94bd324 
…738/Crescendo2024 into led-control-using-pwm
@derp00monsta @GalexY727
Convert the Poses to Translations for LPI
ad29fba 
also makes a wheel array for the SwerveDriveKinematics

Co-authored-by: Alexander Hamilton <a.hamilton72006@gmail.com>
@derp00monsta
Merge branch 'led-control-using-pwm' of https://github.com/Patribots4…
711b893 
…738/Crescendo2024 into led-control-using-pwm
@GalexY727
import who art thou
90c2e0a
@GalexY727 @derp00monsta @Jacob1010-h
Add the LPI command its own file and make setter methods for the leds…
e565b90 
…' color

Co-authored-by: Tina H <derp00monsta@users.noreply.github.com>
Co-authored-by: Jacob Hotz <Jacob1010-h@users.noreply.github.com>
@GalexY727
add documentation to getmoduleposition
586c34d
@derp00monsta @rin-star @GalexY727
This for *sure* is shrimple enough to work 🦐😃
0f5427c 
Co-authored-by: rin-star <rin-star@users.noreply.github.com>
Co-authored-by: Alexander Hamilton <65139378+GalexY727@users.noreply.github.com>
@derp00monsta @GalexY727
Make the enums enumign more :>
45b0e39 
Co-authored-by: Alexander Hamilton <a.hamilton72006@gmail.com>
@derp00monsta @GalexY727
Add comments and correct isFinished boolean
9448c17 
Co-authored-by: Alexander Hamilton <a.hamilton72006@gmail.com>
GalexY727
GalexY727 requested changes Feb 1, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes needed, looks pretty good :)
Do you want to schedule this command when in RobotContainer's onDisabled is called? Or just when the robot initially starts? You don't have to do either, just think about it

src/main/java/frc/robot/Robot.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Show resolved Hide resolved
src/main/java/frc/robot/commands/leds/LPI.java Show resolved Hide resolved
src/main/java/frc/robot/subsystems/LedStrip.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/LedStrip.java Outdated Show resolved Hide resolved
@derp00monsta derp00monsta self-assigned this Feb 1, 2024
@derp00monsta derp00monsta added enhancement New feature or request logic A logic problem or solution command A command on the robot that controls a subsystem labels Feb 1, 2024
@derp00monsta
Copy link
Contributor Author

@GalexY727 I think I fixed your comments?

@derp00monsta
Copy link
Contributor Author

O and why is LPI in a LED folder by itself? Can I remove the folder and just have the file directly belong to commands?

@derp00monsta @rin-star @frighthunt
Integrate LPI in RobotContainer
e6f39d0 
Co-authored-by: rin-star <rin-star@users.noreply.github.com>
Co-authored-by: frighthunt <frighthunt@users.noreply.github.com>
GalexY727
GalexY727 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so good you know, itll surely work first try :D

@GalexY727 GalexY727 merged commit e1801d9 into main Feb 2, 2024
1 check passed
@GalexY727 GalexY727 deleted the led-control-using-pwm branch February 2, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalexY727 GalexY727 GalexY727 approved these changes

Assignees

@derp00monsta derp00monsta

Labels
command A command on the robot that controls a subsystem enhancement New feature or request logic A logic problem or solution
Projects
Crescendo 2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@derp00monsta @GalexY727 @PatribotsProgramming @TotalMoron @BredPerson @Jacob1010-h