Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pivot+shooter testing #111

Merged
merged 11 commits into from
Feb 2, 2024
Merged

Pivot+shooter testing #111

merged 11 commits into from
Feb 2, 2024

Conversation

Oliver-Cushman
Copy link
Contributor

Have this working shooter here you go

@Oliver-Cushman Oliver-Cushman linked an issue Feb 2, 2024 that may be closed by this pull request
Component Unit Tests #99
Closed
5 tasks
@Oliver-Cushman
Copy link
Contributor Author

No unit tests yet, just wanted to get working shooter on main

@Oliver-Cushman Oliver-Cushman removed a link to an issue Feb 2, 2024
Component Unit Tests #99
Closed
5 tasks
GalexY727
GalexY727 requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation in robotcontainer needs to be fixed. I will not allow 8 spaces for
e v e r y s i n g l e t a b
Also, the advantagescope assets should be directly up to date with main

@GalexY727 GalexY727 merged commit 02ab4d1 into main Feb 2, 2024
1 check passed
@GalexY727 GalexY727 deleted the Pivot+Shooter-Testing branch February 2, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalexY727 GalexY727 GalexY727 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oliver-Cushman @GalexY727 @Jacob1010-h @PatribotsProgramming