Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

131 calibrate the shooter pivot speeds etc without redeploying #134

Merged
merged 9 commits into from
Feb 8, 2024
Merged

131 calibrate the shooter pivot speeds etc without redeploying #134

merged 9 commits into from
Feb 8, 2024

Conversation

Jacob1010-h
Copy link
Member

No description provided.

@Jacob1010-h Jacob1010-h requested a review from GalexY727 February 5, 2024 20:30
@Jacob1010-h Jacob1010-h self-assigned this Feb 5, 2024
@Jacob1010-h Jacob1010-h linked an issue Feb 5, 2024 that may be closed by this pull request
A way to calibrate the shooter (pivot, speeds, etc...) without redeploying #131
Closed
GalexY727
GalexY727 requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly formatting, the logic looks like it works :>

src/main/java/frc/robot/util/CalibrationControl.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/CalibrationControl.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/CalibrationControl.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/CalibrationControl.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/Constants.java Outdated Show resolved Hide resolved
GalexY727
GalexY727 requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed 🦒

I would make distance always in feet, since Line 177 just does a ++ operation and we don't want to jump from 0m to 1m we want to jump from 0ft to 1ft

src/main/java/frc/robot/util/PatriBoxController.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/CalibrationControl.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/Constants.java Outdated Show resolved Hide resolved
@Jacob1010-h Jacob1010-h changed the base branch from main to calibration-control February 6, 2024 22:05
@Jacob1010-h
Copy link
Member Author

@GalexY727 I need one more review!

GalexY727
GalexY727 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is all good if you want to go ahead and merge, but I still have some things I wanted to comment on if you would like to look through those.

src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/CalibrationControl.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/CalibrationControl.java Outdated Show resolved Hide resolved
GalexY727
GalexY727 requested changes Feb 8, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I take it back I CHANGED my MIND I want those buttons to be togglesSSSS D: (~RobotContainer L#254)

@Jacob1010-h Jacob1010-h merged commit 9ae9560 into calibration-control Feb 8, 2024
@Jacob1010-h Jacob1010-h deleted the 131-calibrate-the-shooter-pivot-speeds-etc-without-redeploying branch February 8, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalexY727 GalexY727 GalexY727 requested changes

Assignees

@Jacob1010-h Jacob1010-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A way to calibrate the shooter (pivot, speeds, etc...) without redeploying
2 participants
@Jacob1010-h @GalexY727