Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

158 hdc tuner better #159

Merged
merged 12 commits into from
Feb 16, 2024
Merged

158 hdc tuner better #159

merged 12 commits into from
Feb 16, 2024

Conversation

Jacob1010-h
Copy link
Member

No description provided.

@Jacob1010-h Jacob1010-h added the enhancement New feature or request label Feb 14, 2024
@Jacob1010-h Jacob1010-h added this to the Autonomous Tuning milestone Feb 14, 2024
@Jacob1010-h Jacob1010-h self-assigned this Feb 14, 2024
@Jacob1010-h Jacob1010-h linked an issue Feb 14, 2024 that may be closed by this pull request
HDC Tuner #158
Closed
@PatribotsProgramming PatribotsProgramming requested review from RudyG252 and PatribotsProgramming and removed request for GalexY727 and RudyG252 February 14, 2024 02:11
PatribotsProgramming
PatribotsProgramming requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@PatribotsProgramming PatribotsProgramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test in simmmm-- but other than that just make sure that we don't make a new hdc every loop. it takes up a LOT of time

src/main/java/frc/robot/util/HDCTuner.java Outdated Show resolved Hide resolved
Jacob1010-h and others added 3 commits February 13, 2024 18:17
@Jacob1010-h
hehehe oops
3d5f865
@Jacob1010-h
update constants
66ca665
@GalexY727
a lighthearted attempt at making a simple hdc tuner
00b01a6 
-- should we have a square auto (that spins) running on repeat?
@GalexY727 GalexY727 requested review from GalexY727 and RudyG252 and removed request for GalexY727 February 15, 2024 10:29
@GalexY727
Copy link
Member

i tested in sim btw it's workin pretty nicely.

@PatribotsProgramming PatribotsProgramming merged commit ef93bbb into calibration-control Feb 16, 2024
@PatribotsProgramming PatribotsProgramming deleted the 158-hdc-tuner-better branch February 16, 2024 22:29
@PatribotsProgramming PatribotsProgramming mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatribotsProgramming PatribotsProgramming PatribotsProgramming requested changes

@RudyG252 RudyG252 Awaiting requested review from RudyG252

Assignees

@Jacob1010-h Jacob1010-h

Labels
enhancement New feature or request
Projects
None yet
Milestone
Autonomous Tuning
Development

Successfully merging this pull request may close these issues.

HDC Tuner
3 participants
@Jacob1010-h @GalexY727 @PatribotsProgramming