Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source alignment #176

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Source alignment #176

merged 3 commits into from
Feb 22, 2024

Conversation

Oliver-Cushman
Copy link
Contributor

No description provided.

@Oliver-Cushman Oliver-Cushman requested review from GalexY727 and Jacob1010-h and removed request for GalexY727 February 21, 2024 23:41
Copy link
Member

@Jacob1010-h Jacob1010-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the geometry utils that u talked about with me, this looks good to go

@@ -569,6 +570,11 @@ public static final class FieldConstants {
new Pose2d(11.655, 4.064, new Rotation2d())
};

public static final Pose2d[] SOURCE_POSITIONS = new Pose2d[] {
new Pose2d(15.452, 0.971, Rotation2d.fromDegrees(120)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u might want to add some geometry utils to swap this with a method, liked u talked abt with me.

@Jacob1010-h Jacob1010-h merged commit c80d1a9 into sim-dev Feb 22, 2024
@Jacob1010-h Jacob1010-h deleted the source-alignment branch February 22, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants