Angle reset2 #193
Merged
Angle reset2 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopefull right co-authored by hadizah
PatribotsProgramming
requested changes
Feb 25, 2024
Comment on lines
147
to
156
| * The function is a command that resets the angle of the robot | ||
| * to be at the min angle. | ||
| * | ||
| * @return The method is returning a Command object. | ||
| */ | ||
|
|
||
| public Command angleReset() { | ||
| return Commands.runOnce(() -> pivot.setAngle(ShooterConstants.PIVOT_LOWER_LIMIT_DEGREES)); | ||
| } | ||
|
|
PatribotsProgramming
requested changes
Feb 25, 2024
Comment on lines
270
to
271
| pieceControl.shootWhenReady(swerve::getPose, swerve::getRobotRelativeVelocity) | ||
| .andThen(pieceControl.resetPivotAngle())); |
There was a problem hiding this comment.
This should be a part of shootwhenready so that this .andthen doesn't have to be inside of robotcontainer
src/main/java/frc/robot/commands/subsytemHelpers/PieceControl.java
Outdated
Show resolved
Hide resolved
|
note to self: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review this one
hopefully it is right 👍