Dynamic auto with object detection #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ked in!" This reverts commit 0356c8f.
…into 184-documentation-its-time-to-get-working
Co-authored-by: rin-star <rin-star@users.noreply.github.com>
Oliver-Cushman
added
enhancement
Oliver-Cushman
added
the
command
Oliver-Cushman
requested review from
Jacob1010-h and
GalexY727
and removed request for
GalexY727 and
Jacob1010-h
Jacob1010-h
requested changes
Feb 25, 2024
src/main/java/frc/robot/subsystems/misc/limelight/Limelight.java
Outdated
Show resolved
Hide resolved
…rescendo2024 into object-detection
GalexY727
approved these changes
Feb 26, 2024
src/main/java/frc/robot/commands/autonomous/PathPlannerStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/commands/autonomous/PathPlannerStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/commands/subsytemHelpers/AlignmentCmds.java
Outdated
Show resolved
Hide resolved
Comment on lines
+383
to
+385
| public Command getChaseCommand() { | ||
| return new ChasePose(this); | ||
| } |
There was a problem hiding this comment.
It might be fine to just have one instance of this command and instead reschedule the command. This would prevent constructor logic from re-running so that logic might need to be moved into ChasePose::initialize if it is required to run upon making a new command
|
@Oliver-Cushman Feel free to be the one who merges this pull request when you are comfortable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses limelight object detection logic to go to notes it sees and pathplanner pathfinding to return to a shooting pose. Extra review would be appreciated in Limelight.java as I am not the most familiar with our vision system.