Climb logic -> Main (#97) #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the config shrimple to drive
…ually be the demise of #97
GalexY727
added
enhancement
1 task
RudyG252
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Looks good, didn't look too much into the math but it looks simple and I trust you on that :D. One small thing, the change with starting index and ending index with checking which alliance we're on seems redundant. Why don't we just find the nearest chain to us without worrying about that?
Yeah. I thought about this. It's only calculating three values, so I don't know if it's worth it. |
|
This merge also contains some formatting fixes |
Jacob1010-h
reviewed
Feb 1, 2024
|
|
||
| public class PoseCalculations { | ||
| public class PoseCalculations implements Logged { |
There was a problem hiding this comment.
this doesn't need to be here anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using three preset positions for the robot to have the climb prepare for, why not make it the whole chain?
Preview:
Closes #97