Skip to content

Commit

Permalink
[notes:rust/dot-dsl] New points
Browse files Browse the repository at this point in the history
Signed-off-by: Paul Mabileau <paulmabileau@hotmail.fr>
  • Loading branch information
PaulDance committed Feb 17, 2021
1 parent 051ea3f commit b57b2a8
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions notes/rust/dot-dsl.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
Good job on passing all the tests!

* I like the use of macros.
* It's good that you factorize the duplicate functions.

You can reduce the duplication of code by either:
* Implementing a function common to all three structures and call it from
their respective `with_attrs` method.
Expand Down

0 comments on commit b57b2a8

Please sign in to comment.