Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple benchmark for Forth rust track #14

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Simple benchmark for Forth rust track #14

merged 2 commits into from
Mar 3, 2021

Conversation

francescoalemanno
Copy link
Contributor

No description provided.

Copy link
Owner

@PaulDance PaulDance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @francescoalemanno!

Thanks for this, I really appreciate the contribution. I left a comment suggesting a small change, so we should be able to merge this soon. Also, if you have time to look for various solutions that show different behaviors performance-wise and add the results to the mentoring notes, it could make another great PR ;)

benches/rust/forth.rs Outdated Show resolved Hide resolved
Co-authored-by: Paul Mabileau <35344098+PaulDance@users.noreply.github.com>
@francescoalemanno
Copy link
Contributor Author

Hi Paul! I just accepted your changes. Yes, I will definitely do that 👍🏼 ;)

Copy link
Owner

@PaulDance PaulDance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, everything is good, thanks!

@PaulDance PaulDance merged commit 53df178 into PaulDance:master Mar 3, 2021
@PaulDance PaulDance added benchmarks Concerns exercise custom benchmarks enhancement New feature or request labels Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Concerns exercise custom benchmarks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants