-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Commit for Plotting Templates #1
Initial Commit for Plotting Templates #1
Conversation
@PaulTalbot-INL A few design questions for the plotting outstreams. I've currently setup the |
I think right now when debug mode is enabled we're changing the return from Inner to Outer to go from being the sweep values to the dispatch results instead, so the outer can do the plotting (and place it somewhere easy to find). Like you suggest, I think we have the driver write the plot Step into the Outer after the MultiRun. |
This commit now appropriatley automates adding plot specific nodes to the outer.xml files
@PaulTalbot-INL This PR is pretty much ready for a once over. There are probably a few more details that I will add, but I believe the main logic and documentation is written for the debug plotting. |
Okay, I'm starting into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things to at least consider before we merge it in
@@ -15,6 +15,7 @@ | |||
<debug> | |||
<inner_samples>2</inner_samples> | |||
<macro_steps>2</macro_steps> | |||
<dispatch_plot>True</dispatch_plot> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add to the debug test a check for the existence of the output png (we don't need to test the image contents itself imo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a debug test already? If not I can just add the output check when I add the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is a debug unit test but there is a debug integration test.
@PaulTalbot-INL here is a plot output |
I would like to change the color cycle so that we get different colors for each resource. |
Yeah, coordinating colors through identifying unique components would be good (resources are already grouped, right?). We could also simplify the labels to be only the unit, right, since it's all dispatch, although maybe for readability e.g. Steamer Dispatch would be more human than just Steamer? Either way we probably don't need to reiterate the resource, right? |
Someday maybe we add user-defined units for the X and Y axes, but for now this gives enough indication, and they have the CSV with the data if they want to make a production-worthy plot. |
@PaulTalbot-INL Yes, I think streamlining the labels will be best. I'll make that change. And I totally agree, something the user can specify for y-axis labels would be nice but for the debug it might be okay to leave it blank as just a visual indicator. |
[./debug_plot] | ||
type = NetCDF | ||
output = 'Debug_Run_o/dispatch_id0_y10_c0.png' | ||
gold_files = 'gold/dispatch_id0_y10_c0.png' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the output needs a gold file, since it just checks generation, but I can see what this does later.
Merging to development branch, which will have SQA checklists performed before merging to |
Added TODO comments where debug case handling could use some work
Fixing issue with FARM validator test
Pull Request Description
What issue does this change request address?
This is a PR that will later be merged onto HERON devel.
What are the significant changes in functionality due to this change request?
This PR adds the plotting outstream templates for the dispatch plots in HERON.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.