Two tests (1 failing) showing Collection reset/set should both link related objects

[philfreo]

I got bit by this by changing a foo.fetch() to foo.fetch({ reset: true }) in my app, and relations stopped working properly.

Here are two tests that should both have the same behavior, but the "reset" one fails.

FYI I'm using the 'this.set()' in Address#initialize because I don't want fetchRelated() to run, since I know that there's already an ajax request fired to fetch all "countries"

[PaulUithol]

Hmm.. I'm not sure about this one. One the one hand, I wouldn't call it 'desired' behavior per se. However, it is very much the expected behavior:

• Collection.reset calls Collection.add
• Collection.add sets it's default options; add: true, merge: false, remove: false
• Collection.add calls Collection.set
• the model doesn't get updated.

We could set merge: true as a default option in reset, but I'm wondering if that behavior would be better? You could also change the call to countries.reset( [ { id: 'US', name: 'United States' } ], { merge: true } );.

[PaulUithol]

Okay, I've made this change. For BBR, merging on reset is probably the most common use case; if it's not desired, you can pass merge: false.

[philfreo]

Makes sense - thanks!!