Re-add ability to gather penalties for all validators

[kellybyrd]

This is a re-implementation of 21b8d99
after the switch to JSON-RPC:

Add an envvar (defaults to off) that will gather penalties for
all validators from the ledger.

Unlike the previous version, this one does not exclude the 0 penalty
validators.

[kellybyrd]

@PaulVMo I did this REALLY quick and need to step away for a bit. It appeared to work for at least one case, but I haven't tested it well. I'll do that later.

[PaulVMo]

Yeah that's what I was referring to, use penalty_ledger even in the case of the single validator. I did forget that this_validator was used later

…

On Mon, Nov 29, 2021, 7:49 PM Kelly Byrd ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In miner_exporter.py <#2 (comment)>: > @@ -182,12 +194,13 @@ def stats(miner: MinerJSONRPC): if version is not None: VALIDATOR_VERSION.labels(my_label).info({'version':version}) - if this_validator is not None: I don't follow. In the new if/else starting on line 120 above, penalty_ledger contains either either the full set or just "this one". I did that so the for loop below here (starting on 198) can loop over penalty_ledger in all cases. The only reason I kept using this_validator above was because I saw that other things in the code referenced it and I was moving fast to get this up before I has to leave. this_validator ends up being just a copy of one entry from penalty_ledger. It's probably cleaner to have everything always refer to penalty_ledger — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLJDYNIUZC6VZ5IA7OYAX3UOQUTXANCNFSM5JANVQOQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.