Generate Map/Switch if the number of items is less than 1000

PawelGerr · Nov 17, 2023 · e5ca209 · e5ca209
1 parent 7ecd860
commit e5ca209
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -2,7 +2,7 @@
 
    <PropertyGroup>
       <Copyright>(c) $([System.DateTime]::Now.Year), Pawel Gerr. All rights reserved.</Copyright>
-      <VersionPrefix>6.5.1</VersionPrefix>
+      <VersionPrefix>6.5.2</VersionPrefix>
       <Authors>Pawel Gerr</Authors>
       <GenerateDocumentationFile>true</GenerateDocumentationFile>
       <PackageProjectUrl>https://github.com/PawelGerr/Thinktecture.Runtime.Extensions</PackageProjectUrl>

diff --git a/...hinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/AllEnumSettings.cs b/...hinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/AllEnumSettings.cs
@@ -12,8 +12,8 @@ public sealed class AllEnumSettings : IEquatable<AllEnumSettings>
    public OperatorsGeneration EqualityComparisonOperators { get; }
    public bool SkipIFormattable { get; }
    public bool SkipToString { get; }
-   public bool SkipSwitchMethods { get; }
-   public bool SkipMapMethods { get; }
+   public bool? SkipSwitchMethods { get; }
+   public bool? SkipMapMethods { get; }
 
    public AllEnumSettings(AttributeData? attribute, bool isValidatable)
    {
@@ -25,8 +25,8 @@ public AllEnumSettings(AttributeData? attribute, bool isValidatable)
       EqualityComparisonOperators = attribute?.FindEqualityComparisonOperators() ?? OperatorsGeneration.Default;
       SkipIFormattable = attribute?.FindSkipIFormattable() ?? false;
       SkipToString = attribute?.FindSkipToString() ?? false;
-      SkipSwitchMethods = attribute?.FindSkipSwitchMethods() ?? false;
-      SkipMapMethods = attribute?.FindSkipMapMethods() ?? false;
+      SkipSwitchMethods = attribute?.FindSkipSwitchMethods();
+      SkipMapMethods = attribute?.FindSkipMapMethods();
 
       // Comparison operators depend on the equality comparison operators
       if (ComparisonOperators > EqualityComparisonOperators)

diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/EnumSettings.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/EnumSettings.cs
@@ -7,8 +7,8 @@ namespace Thinktecture.CodeAnalysis.SmartEnums;
 
    public bool IsValidatable => _settings.IsValidatable;
    public bool SkipToString => _settings.SkipToString;
-   public bool SkipSwitchMethods => _settings.SkipSwitchMethods;
-   public bool SkipMapMethods => _settings.SkipMapMethods;
+   public bool? SkipSwitchMethods => _settings.SkipSwitchMethods;
+   public bool? SkipMapMethods => _settings.SkipMapMethods;
    public bool HasStructLayoutAttribute => _attributeInfo.HasStructLayoutAttribute;
    public IReadOnlyList<DesiredFactory> DesiredFactories => _attributeInfo.DesiredFactories;
 

diff --git a/...ture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/SmartEnumCodeGenerator.cs b/...ture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/SmartEnumCodeGenerator.cs
@@ -166,15 +166,17 @@ public override int GetHashCode()
       if (!_state.Settings.SkipToString)
          GenerateToString();
 
-      if (!_state.Settings.SkipSwitchMethods)
+      var hasSaneNumberOfItems = _state.ItemNames.Count < 1000;
+
+      if (!_state.Settings.SkipSwitchMethods.GetValueOrDefault() && hasSaneNumberOfItems)
       {
          GenerateSwitchForAction(false);
          GenerateSwitchForAction(true);
          GenerateSwitchForFunc(false);
          GenerateSwitchForFunc(true);
       }
 
-      if (!_state.Settings.SkipMapMethods)
+      if (!_state.Settings.SkipMapMethods.GetValueOrDefault() && hasSaneNumberOfItems)
          GenerateMap();
 
       GenerateGetLookup();