DES-882: Modal now resizes when browser is resized #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLantz
approved these changes
Jan 12, 2018
mhomolak
approved these changes
Jan 12, 2018
wyseguyonline
approved these changes
Jan 12, 2018
|
Setting { 'leading': true } did not help in this case of resizing. |
|
Ready for QA or something 😃 |
…, including IE 11
|
@JasonLantz Eajaz discovered that the demo was not working in IE 11. This was due to webpack-dev-server 2.11.x having a dependency on strip-ansi 4.0, which used arrow functions, which are not supported in IE 11. For a quick fix, I pinned the webpack-dev-server at 2.9.x, which uses strip-ansi 3.x. Read all about it here: webpack/webpack-dev-server#1278. Here is a possible PR for webpack-dev-server to resolve this issue: webpack/webpack-dev-server#1273 |
|
all approved. merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.