-
Notifications
You must be signed in to change notification settings - Fork 17
Update contributors.js
with new contributors
#35
Conversation
In addition to the modifications I've proposed, I've noticed some inconsistencies within the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the following comments from the issue #32 :
Also, I wonder if we could create a section on project alumni. Probably just names not pictures. There we could add a number of people who came and went since that page was last updated (grad students, postdocs, GSOC students, etc)
And/or we could link to the github project contribitors page https://github.com/PecanProject/pecan/graphs/contributors
Yeah Sure. I'm thinking to proceed as follow :
<h2 style={{ textAlign: "center",margin:'0.5rem' }}>Project Alumni</h2>
<AlumniList/> This section will be integrated below the
I think we should include a link at the footer with |
@RohanSasne I'm proceeding forward with the changes I've proposed in above message. All edits and responses are welcome. |
Created a seperate Alumni section enlisting previous GSoC contributors
Added contributors Section to footer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So sorry for the delay in review, super busy these days :)
I appreciate your efforts @Sweetdevil144 , just completed the review, thanks a lot for the PR, we're good to go!
You can also find issues in our main project repository : https://github.com/PecanProject/pecan/issues
I really wish to see you around more often with us and hope you keep contributing to our community :)
Fixes #32
As Described by @RohanSasne , following changes were made :