This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Don't allow creation of multiple gauges with the same name #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Creating multiple gauges with the same name results in only the first created one actually having any effect (because a supplier is passed in that the data is always pulled from). If we're creating gauges in objects that are discarded and recreated the metrics will be wrong and we probably leaked memory because of the on-going reference to the first created metric.
We're not currently creating multiple gauges with the same name so go back to throwing an exception if we ever try to.