This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2893] Rename privacyGroupId to createPrivacyGroupId #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puneetha17
changed the title
|
Per our conversation, Is this going to change to "createPrivacyGroup"? |
shemnon
approved these changes
Jul 12, 2019
Also add test for eea_createPrivacyGroup
iikirilov
force-pushed
the
createGroupTest
branch
from
0dcd2fa
to
ea1398e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
In accordance with the changes, Consensys/orion#251, in
Orionto clarify thecreatePrivacyGroupIdAPI.Also added test for eea_createPrivacyGroup.