This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2756] EIP-2028 - Reduce intrinsic gas cost #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the non-zero byte of intrinsic gas cose from 68 to 16. Keep all other values the same.
shemnon
changed the title
mbaxter
approved these changes
Jul 23, 2019
| if (payload.get(i) == 0) { | ||
| ++zeros; | ||
| } | ||
| } |
There was a problem hiding this comment.
(optional) would be nice to dedupe this zero counting logic
| @@ -110,7 +110,7 @@ public ExecutionContextTestFixture build() { | |||
| if (protocolSchedule == null) { | |||
| protocolSchedule = | |||
| new ProtocolScheduleBuilder<>( | |||
| new StubGenesisConfigOptions().istanbulBlock(0), | |||
| new StubGenesisConfigOptions().constantinopleFixBlock(0), | |||
There was a problem hiding this comment.
The prices changed and the old unit tests were based on Petersburg prices. I had speculatively changed this test to Istanbul when I added Istanbul support now I'm moving it back. Once Istanbul is on mainnet we should revisit these tests and assertions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Reduce the non-zero byte of intrinsic gas cose from 68 to 16.
Keep all other values the same.