This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 130
Added note about private transaction nonce #1740
Merged
MadelineMurray
merged 23 commits into
PegaSysEng:master
from
MadelineMurray:privateTransactionNonce
Jul 25, 2019
Merged
Added note about private transaction nonce #1740
MadelineMurray
merged 23 commits into
PegaSysEng:master
from
MadelineMurray:privateTransactionNonce
Jul 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…managingPrivateTransactions
…managingPrivateTransactions
…heon into MadelineMurray-privacyReorg
…MadelineMurray-privacyReorg
…lineMurray/pantheon into MadelineMurray-managingPrivateTransactions
bgravenorst
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
antonydenyer
suggested changes
Jul 24, 2019
@@ -3875,6 +3875,9 @@ Privacy groups containing only the specified members. | |||
|
|||
Returns the private transaction count for specified account and privacy group. | |||
|
|||
!!! important | |||
If sending a large number of private transactions, calculate the private transaction nonce outside Pantheon. | |||
|
|||
**Parameters** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If sending more than 1 transaction that will be mined in the same block (ie you're not waiting for the transaction receipt) then you must calculate ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
…Murray/pantheon into privateTransactionNonce
antonydenyer
approved these changes
Jul 24, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 26, 2019
MadelineMurray
added a commit
to MadelineMurray/pantheon
that referenced
this pull request
Jul 28, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 28, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note about private transaction nonce