This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2727] Permissioning Acceptance Test - Verify OnChain Nodes Out of Sync #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Verify that while a new node is being added and is out of sync, it doesnt accept connections, it accepts connection once it is synced
macfarla
approved these changes
Jul 25, 2019
|
|
||
| @Test | ||
| public void testOutOfSyncNodeConnectionToPeers() { | ||
| final long blockChainHeight = 50L; |
There was a problem hiding this comment.
nit: s/blockChain/blockchain
There was a problem hiding this comment.
is 50 enough for a reliable test?
| } | ||
|
|
||
| @Test | ||
| public void testOutOfSyncNodeConnectionToPeers() { |
There was a problem hiding this comment.
prob could have a better test name - maybe addingNodeToClusterSyncsAndThenConnectsToNonBootnodePeer
-- Incorporating review suggestions
lucassaldanha
approved these changes
Jul 25, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 26, 2019
…f Sync (PegaSysEng#1759) -- Verify that while a new node is being added and is out of sync, it doesn't accept connections, it accepts connection once it is synced
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add acceptance test that verifies that while a new node is being added to OnChain and is out of sync, it doesn't accept connections. Once synced, it starts accepts connection from allowed nodes.