Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PAN-2996] Remove enclave public key from parameter #1789

Merged
merged 5 commits into from
Jul 31, 2019

Conversation

iikirilov
Copy link
Contributor

@iikirilov iikirilov commented Jul 30, 2019

PR description

Enforce that the creator of a privacy group is the node. This simplifies the privacy group creation process and inhibits users to make mistakes when attempting to create a privacy group.

Fixed Issue(s)

PAN-2996

Copy link
Contributor

@MadelineMurray MadelineMurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works

Copy link
Contributor

@MadelineMurray MadelineMurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But name and description don't seem to be optional anymore

@iikirilov
Copy link
Contributor Author

They never were. This PR makes that happen.

N.B. The order of the parameters has changed such that the mandatory parameters come first.

Copy link
Contributor

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants