This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-1561] Remove RLPUtils from RawBlockIterator #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create BytesValue backed by ByteBuffer, extract some functionality from RLPInput into static helper methods.
Standardize behavior across implementations. Fix bug in ByteBuffer wrapping BytesValue (byte access should include offset).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR removes
RLPUtilsfromRawBlockIterator, as part of the work to removingRLPUtilsaltogether.In order to remove this utility, I added a
BytesValueclass that wraps aroundjava.nio.ByteBuffer. The purpose of theBytesValueabstraction is to allow our apis to work generically across various types that represent byte strings, so I felt that it was worth expanding the library to support this common type. Adding anotherBytesValuewrapper is pretty straightforward. However, the tests were not set up to run across the variousBytesValueimplementations. So, I spent some time refactoring the tests to get better coverage across the different implementations as well as standardizing some behavior across implementations.In order to support the functionality that was previously provided by
RLPUtils, I also had to refactor the rlp library to extract some functionality fromAbstractRLPInputso that it could be used in a static helper method inRLP.I added tests for
RawBlockIteratorand additional test coverage for the areas of the rlp functionality that were refactored.Note: Re-creating this PR after open-sourcing issues caused my previous PR to be closed: #143