This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[MINOR] Render handler exception to System.err instead of .out #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
reviewed
Nov 29, 2018
| private void handleException(final Throwable throwable) { | ||
| System.out.println(throwable); | ||
| private void handleException(final Throwable exception) { | ||
| System.err.println(String.format("Packet handler exception: %s.", exception.getMessage())); |
There was a problem hiding this comment.
Good spot, but this should be sent to a logger, not System.err or System.out and it should include the stack trace, so:
LOG.error("Packet handler exception", exception);
We may want to check the exception type though - IOException is fairly expected in this area so probably should be debug level.
ajsutton
reviewed
Nov 29, 2018
| if (exception instanceof IOException) { | ||
| LOG.debug("Packet handler exception", exception); | ||
| } | ||
| LOG.error("Packet handler exception", exception); |
There was a problem hiding this comment.
missing an else - this will log IOException at both debug and error level.
smatthewenglish
force-pushed
the
handle-exception
branch
from
4d7662d
to
c23eb26
Compare
smatthewenglish
force-pushed
the
handle-exception
branch
from
27cf9df
to
ee3532e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This is somewhat of a drive-by amelioration. I was going to test it but this is actually kind of hard to test, and I didn't want to spend a lot of time trying to make a good test for this, so I almost didn't change it- but anyway- I in fact did test it once, by making the method from
privatetopublicso I know that it behaves as expected.Fixed Issue(s)