This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Validate enodeurl syntax from command line #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the JI about improving the error messages: NC-2015 |
lucassaldanha
force-pushed
the
validate-enodeurl
branch
from
7523b08
to
2656196
Compare
macfarla
reviewed
Dec 12, 2018
pantheon/src/main/java/tech/pegasys/pantheon/cli/custom/EnodeToURIPropertyConverter.java
Outdated
Show resolved
Hide resolved
pantheon/src/test/java/tech/pegasys/pantheon/cli/PantheonCommandTest.java
Show resolved
Hide resolved
pantheon/src/test/java/tech/pegasys/pantheon/cli/custom/EnodeToURIPropertyConverterTest.java
Outdated
Show resolved
Hide resolved
pantheon/src/test/java/tech/pegasys/pantheon/cli/custom/EnodeToURIPropertyConverterTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Now we are using
EnodeToURIPropertyConverterto parse enode URLs from the command line. This applies to--bootnodesand--nodes-whitelist. Also, we are now keeping them as URI instances instead of Strings.Unfortunately, Picocli doesn't handle well error messages for lists that accept zero elements (
--nodes-whitelist). Therefore, the error message when using an invalid enode URL for this property is not as helpful as when you try to do the same with--bootnodes. I'll raise a JI ticket to investigate exxtending PicocliDefaultExceptionHandlerto improve the error message for lists with arity0..*.