Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Blockcreator to use parentblock specified at constuction #588

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

rain-on
Copy link
Contributor

@rain-on rain-on commented Jan 17, 2019

AbstactBlockCreator is given a parentBlock upon which to construct the new block, at construction.

However, during the block creation process, it gets a 2nd parent by going directly to the blockchain.

This is probably erroneous, as all "parent" related tasks conducted by this class should be conducted on that supplied at construction.

@rain-on rain-on requested a review from ajsutton January 17, 2019 04:45
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rain-on rain-on merged commit f3a050d into PegaSysEng:master Jan 17, 2019
@rain-on rain-on deleted the block_creator_parent branch January 24, 2019 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants