This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-2138] Extract out generic parts of Downloader #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of the Downloader logic in preparation for introducing a fast sync chain downloader.
…ync target manager.
mbaxter
approved these changes
Jan 28, 2019
| @@ -98,11 +95,16 @@ public void start() { | |||
| } | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| public CompletableFuture<?> getCurrentTask() { | |||
There was a problem hiding this comment.
Can we make this package-private?
There was a problem hiding this comment.
Sadly no because FullSyncDownloader is under ...sync.fullsync package and FastSyncDownloader will be under ...sync.fullsync so this lives under ...sync. I think it's with this bit of pain to be able to have separate packages for fast sync vs full sync specific bits.
| } | ||
| } | ||
|
|
||
| protected abstract Optional<EthPeer> selectBestAvailableSyncTarget(); |
There was a problem hiding this comment.
This difference here for fast sync is an extra check that the sync target agrees the pivot block is on the canonical chain?
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jan 29, 2019
Separate the management of sync target and actual import from the rest of the Downloader logic in preparation for introducing a fast sync chain downloader.
vinistevam
pushed a commit
to vinistevam/pantheon
that referenced
this pull request
Jan 29, 2019
Separate the management of sync target and actual import from the rest of the Downloader logic in preparation for introducing a fast sync chain downloader.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Extract out the reusable parts of the chain download process into a separate class with pluggable implementations for finding the sync target and creating the block import task. This provides the foundation for adding a fast sync chain downloader.