This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2309] CLI mixin help #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… caused the help to be missing the mixins added
Errorific
reviewed
Feb 19, 2019
| result.errors().stream().map(TomlParseError::toString).collect(Collectors.joining("%n")); | ||
| throw new Exception("Invalid TOML configuration : " + errors); | ||
| result.errors().stream().map(TomlParseError::toString).collect(Collectors.joining("\n")); | ||
| throw new Exception("Invalid TOML configuration : \n" + errors); |
There was a problem hiding this comment.
spurious space between configuration and :
Errorific
approved these changes
Feb 19, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 20, 2019
* don't create a new CommandLine object in the case of exception - this caused the help to be missing the mixins added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Don't create a new CommandLine object in the case of exception (this is why mixins were not showing in the help).
Fixed Issue(s)
fixes #PAN-2309