This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Cleanup ibft logging levels #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain-on
reviewed
Feb 28, 2019
| extraData, | ||
| block.getHeader()); | ||
|
|
||
| LOG.debug("Creating proposed block. round={}", roundState.getRoundIdentifier()); |
There was a problem hiding this comment.
nit: tempted to put a trace in here too with the additional info?
There was a problem hiding this comment.
done. Didn't think it was useful at debug level and it made the logs difficult to read. but at trace it's probably appropriate.
| @@ -94,7 +94,7 @@ public RoundChangeManager( | |||
| public Optional<Collection<RoundChange>> appendRoundChangeMessage(final RoundChange msg) { | |||
|
|
|||
| if (!isMessageValid(msg)) { | |||
| LOG.info("RoundChange message was invalid."); | |||
| LOG.debug("RoundChange message was invalid."); | |||
There was a problem hiding this comment.
Why is an invalid RoundChange debug, but an invalid Proposal an info? (see IbftBlockHeightManager) - I think I prefer info in both places (this is an exceptional behaviour and we want to see it even normally)
| @@ -80,15 +80,13 @@ public boolean setProposedBlock(final Proposal msg) { | |||
| public void addPrepareMessage(final Prepare msg) { | |||
| if (!proposalMessage.isPresent() || validator.validatePrepare(msg)) { | |||
| prepareMessages.add(msg); | |||
| LOG.debug("Round state added prepare message prepare={}", msg); | |||
There was a problem hiding this comment.
nit: not even trace? ... maybe not ... (just want to confirm!)
rain-on
approved these changes
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Updating IBFT logging levels to make more consistent.
Debug level is now predominately about the state machine send, receives and quorums.
Info now also includes validation failures so that is visible.
Trace now alsol includes additional receives in parts of the state machine
Fixed Issue(s)