Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable multi-PLD PCASL support #250

Closed
tsalo opened this issue Apr 4, 2023 · 0 comments · Fixed by #268
Closed

Re-enable multi-PLD PCASL support #250

tsalo opened this issue Apr 4, 2023 · 0 comments · Fixed by #268
Assignees
@tsalo
Labels
enhancement New feature or request
Milestone
0.4.0

Comments

@tsalo
Copy link
Member

tsalo commented Apr 4, 2023 •
edited
Loading

Summary

I blocked any multi-PLD support in #235, because the averaging formula that was being applied was incorrect, and didn't generalize across the different methods (PCASL, PASL+Q2TIPS, PASL+QUIPSS, PASL+QUIPSSII).

However, we would like to get this working at some point soon.
@tsalo tsalo added the enhancement New feature or request label Apr 4, 2023
@tsalo tsalo self-assigned this Apr 17, 2023
@tsalo tsalo mentioned this issue Apr 21, 2023
Merged
3 tasks
@tsalo tsalo changed the title Re-enable multi-PLD support Re-enable multi-PLD PCASL support Apr 25, 2023
@tsalo tsalo mentioned this issue Apr 25, 2023
Open
@tsalo tsalo added this to the 0.4.0 milestone May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsalo tsalo

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Support single-PLD Q2TIPS PASL and multi-PLD PCASL tsalo/aslprep
1 participant
@tsalo