-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct bolus values in CBF calculation and temporarily disable Q2TIPS, multi-PLD, and no-BolusCutOff processing #235
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 45.09% 45.59% +0.49%
==========================================
Files 129 132 +3
Lines 12302 12461 +159
==========================================
+ Hits 5548 5682 +134
- Misses 6754 6779 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Not sure why the output filenames can be set as inputs when those inputs are never used...
I'm not a core team member, but I'm the one who opened #167. These changes seem reasonable to me, specifically, using |
Thank you for reviewing @andrewrosss. Your input is very much appreciated. |
Happy to help! :) Thanks for the fix! |
Nilearn's maskers add a singleton time dimension when the data are purely spatial.
Starting in 0.12.0, nilearn masker.transform on a 3D image will return a 1D array.
Closes #167.
Changes proposed in this pull request
LabelingDuration
as the bolus value in BASIL CBF calculation. For PASL data, useBolusCutOffDelayTime
instead.I still need to figure out what to do if BolusCutOffFlag is False, as well as if BolusCutOffTechnique is QUIPSS or Q2TIPS.