Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoformat with black and isort #205

Merged
merged 5 commits into from
Feb 14, 2023
Merged

Autoformat with black and isort #205

merged 5 commits into from
Feb 14, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 14, 2023

Closeas #198. This adds a linting job as well.

Changes proposed in this pull request

  • Ignore external libraries in flake8, isort, and black configs.
  • Run isort and black on the internal code.
  • Consolidate test files in one folder.
  • Add a linting step. It didn't run, but I'm not sure why. I'll debug in a future PR.

Documentation that should be reviewed

None

@tsalo tsalo added the maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. label Feb 14, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 39.78% // Head: 39.81% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (a92d3cd) compared to base (3bdca40).
Patch coverage: 58.70% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   39.78%   39.81%   +0.03%     
==========================================
  Files         187      187              
  Lines       20121    20136      +15     
==========================================
+ Hits         8005     8018      +13     
- Misses      12116    12118       +2     
Impacted Files Coverage Δ
aslprep/__main__.py 0.00% <0.00%> (ø)
aslprep/_warnings.py 0.00% <0.00%> (ø)
aslprep/cli/aggregate_qc.py 0.00% <0.00%> (ø)
aslprep/cli/run.py 0.00% <0.00%> (ø)
aslprep/tests/testing.py 0.00% <0.00%> (ø)
aslprep/tests/tests.py 0.00% <0.00%> (ø)
aslprep/tests/utils.py 33.82% <ø> (ø)
aslprep/utils/meepi.py 25.00% <0.00%> (ø)
aslprep/utils/misc.py 100.00% <ø> (ø)
aslprep/utils/sentry.py 0.00% <0.00%> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo marked this pull request as ready for review February 14, 2023 21:29
@tsalo tsalo merged commit 649935b into PennLINC:main Feb 14, 2023
@tsalo tsalo deleted the run-black branch February 14, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants