Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PEP8-noncompliant classes #208

Merged
merged 19 commits into from
Feb 15, 2023
Merged

Rename PEP8-noncompliant classes #208

merged 19 commits into from
Feb 15, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 15, 2023

Closes None. Rename classes that are not PEP8 compliant.

Changes proposed in this pull request

  • Remove unused functions from workflows module.
    • Ultimately, there should be no non-workflow functions in the workflows module. There should also be no interfaces there. And there should be no functions in the interfaces module.
  • Rename refinemask to RefineMask.
  • Rename extractCBF to ExtractCBF.
  • Rename computeCBF to ComputeCBF.
  • Rename cbfcomputation function to compute_cbf.
  • Rename scorescrubCBF to ScoreAndScrubCBF.
  • Rename qccbfge to ComputeCBFQCforGE.
  • Rename qccbf to ComputeCBFQC.
  • Make GatherConfounds IO specs private.
  • Make ASLSummary IO specs private.
  • Make T2SMap IO specs private.
  • Make reports interfaces' IO specs private.
  • Rename cbfqroiquant to ParcellateCBF.
  • Rename extractCB to ExtractCBForDeltaM.

Documentation that should be reviewed

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Feb 15, 2023
@tsalo tsalo merged commit a62ca34 into PennLINC:main Feb 15, 2023
@tsalo tsalo deleted the variable-names branch February 15, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsalo