Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use f-strings for string formatting #209

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 15, 2023

Closes None.

Changes proposed in this pull request

  • Use f-strings instead of % formatting or .formatting.
  • Fix some long lines.

Also deal with some other misc. issues, like long lines.
@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Feb 15, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 40.15% // Head: 40.14% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (35d09a0) compared to base (a62ca34).
Patch coverage: 60.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   40.15%   40.14%   -0.01%     
==========================================
  Files         186      186              
  Lines       19877    19878       +1     
==========================================
  Hits         7981     7981              
- Misses      11896    11897       +1     
Impacted Files Coverage Δ
aslprep/__main__.py 0.00% <0.00%> (ø)
aslprep/cli/parser.py 77.10% <0.00%> (-0.47%) ⬇️
aslprep/cli/run.py 0.00% <ø> (ø)
aslprep/cli/version.py 52.63% <0.00%> (ø)
aslprep/utils/sentry.py 0.00% <0.00%> (ø)
aslprep/workflows/asl/base.py 76.31% <ø> (ø)
aslprep/workflows/asl/ge_utils.py 16.33% <0.00%> (ø)
aslprep/workflows/asl/gecbf.py 11.47% <ø> (ø)
aslprep/workflows/asl/outputs.py 43.53% <ø> (ø)
aslprep/workflows/asl/stc.py 38.88% <ø> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo merged commit d19932a into PennLINC:main Feb 15, 2023
@tsalo tsalo deleted the string-formatting branch February 15, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants