Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on fixing docstrings and splitting modules #210

Merged
merged 22 commits into from
Feb 20, 2023
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 15, 2023

Closes None.

Changes proposed in this pull request

  • Move functions into utils and interfaces into interfaces.
  • Add docstrings when necessary.
  • Start moving modified interfaces/functions from external libraries into main package.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Base: 40.14% // Head: 39.95% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (5dbbe37) compared to base (1c4257c).
Patch coverage: 72.70% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   40.14%   39.95%   -0.20%     
==========================================
  Files         186      192       +6     
  Lines       19878    19940      +62     
==========================================
- Hits         7981     7967      -14     
- Misses      11897    11973      +76     
Impacted Files Coverage Δ
aslprep/__main__.py 0.00% <ø> (ø)
aslprep/cli/aggregate_qc.py 0.00% <0.00%> (ø)
aslprep/cli/workflow.py 46.66% <0.00%> (ø)
aslprep/config.py 89.81% <ø> (ø)
aslprep/utils/bids.py 43.85% <ø> (ø)
aslprep/utils/meepi.py 25.00% <ø> (ø)
aslprep/niworkflows/viz/plots.py 29.60% <12.50%> (-23.77%) ⬇️
aslprep/interfaces/ge.py 25.60% <25.60%> (ø)
aslprep/niworkflows/interfaces/plotting.py 74.57% <50.00%> (-8.57%) ⬇️
aslprep/utils/misc.py 63.54% <63.18%> (-36.46%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo added the maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. label Feb 20, 2023
@tsalo tsalo merged commit f0730df into PennLINC:main Feb 20, 2023
@tsalo tsalo deleted the docstrings branch February 20, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants