Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BIDS-noncompliant derivatives #216

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Rename BIDS-noncompliant derivatives #216

merged 6 commits into from
Feb 22, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 22, 2023

Closes None, but splits off part of #213. There are a number of BIDS-noncompliant derivatives, so I have started renaming them.

This PR doesn't make any substantial changes, though at some point I will tackle those as well.

Changes proposed in this pull request

  • Parcellated time series should have the "atlas" field, rather than overloading "desc".
  • No underscores in entities or suffixes. Not sure how that ever even happened. It's been a strict rule in BIDS since its inception.
  • Fix typo in HarvardOxford derivatives. It was spelled HavardOxford.

@tsalo tsalo added bug Something isn't working breaking-change PRs that change results or interfaces. labels Feb 22, 2023
@tsalo tsalo merged commit ce77706 into PennLINC:main Feb 22, 2023
@tsalo tsalo deleted the bids-compliant-derivs branch February 22, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change PRs that change results or interfaces. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsalo