Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert inversion times to a list for compatility with BASIL interface #222

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 27, 2023

Closes #196.

Changes proposed in this pull request

  • Ensure output of get_tis is a list, rather than a numpy array.

@tsalo tsalo added the bug Something isn't working label Feb 27, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 44.09% // Head: 44.09% // No change to project coverage 👍

Coverage data is based on head (05e1386) compared to base (5d7a622).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files         129      129           
  Lines       12364    12364           
=======================================
  Hits         5452     5452           
  Misses       6912     6912           
Impacted Files Coverage Δ
aslprep/utils/misc.py 63.54% <66.66%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo merged commit bcbcac7 into PennLINC:main Feb 27, 2023
@tsalo tsalo deleted the fix-tis branch February 27, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants