Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Nipreps configuration and maintenance docs #231

Merged
merged 39 commits into from
Jun 7, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 10, 2023

Prepare to properly integrate ASLPrep into the Nipreps ecosystem.

I still need to figure out licensing information.

Changes proposed in this pull request

@tsalo tsalo added the maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. label Mar 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: -3.24 ⚠️

Comparison is base (56298bf) 66.05% compared to head (2caf563) 62.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   66.05%   62.82%   -3.24%     
==========================================
  Files          74       56      -18     
  Lines        6072     5103     -969     
  Branches        0      707     +707     
==========================================
- Hits         4011     3206     -805     
+ Misses       2061     1650     -411     
- Partials        0      247     +247     
Impacted Files Coverage Δ
aslprep/utils/sentry.py 0.00% <0.00%> (ø)
aslprep/workflows/base.py 84.14% <ø> (-8.54%) ⬇️
aslprep/__about__.py 100.00% <100.00%> (ø)

... and 48 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo marked this pull request as ready for review June 7, 2023 13:59
@tsalo tsalo merged commit f23e646 into PennLINC:main Jun 7, 2023
@tsalo tsalo deleted the maintenance-docs branch June 7, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve contributing and installation documentation
2 participants