Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor confounds and QC metrics #256

Merged
merged 10 commits into from
Apr 7, 2023
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 6, 2023

Closes none.

Changes proposed in this pull request

  • Combine ComputeCBFQC and ComputeCBFQCforGE into ComputeCBFQC.
    • The only differences, as far as I could tell, were (1) the tissue probability threshold for GE scans was 0.8 instead of 0.7 and (2) mean FD and RMSD were only calculated for non-GE data.
    • Move ComputeCBFQC from aslprep.interfaces.cbf_computation to new aslprep.interfaces.qc.
  • Lightly refactor some of the functions in aslprep.utils.qc. There's still a lot to do there though.
  • Combine init_cbfqc_compt_wf and init_cbfgeqc_compt_wf into aslprep.workflows.qc.init_compute_cbf_qc_wf.
    • The only differences were that the non-GE version uses the confounds matrix and RMSD file, which don't exist for GE data.
    • Add a parameter, is_ge, to handle the differences.

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Apr 6, 2023
@tsalo tsalo marked this pull request as ready for review April 7, 2023 13:27
@tsalo tsalo merged commit ec8ce93 into PennLINC:main Apr 7, 2023
@tsalo tsalo deleted the refactor-confounds branch April 7, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant