-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor more #264
Merged
Merged
Refactor more #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it easier to combine init_asl_t1_trans_wf and init_asl_t1_getrans_wf.
tsalo
added
the
refactor
Changes to the codebase that don't impact workflow inputs or outputs.
label
Apr 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #265.
Changes proposed in this pull request
init_cbf_compt_wf
toinit_compute_cbf_wf
.init_gecbf_compt_wf
toinit_compute_cbf_ge_wf
.init_asl_confs_wf
toinit_asl_confounds_wf
.init_asl_geref_wf
toinit_asl_reference_ge_wf
.init_asl_gereg_wf
toinit_asl_reg_ge_wf
.init_asl_t1_getrans_wf
toinit_asl_t1_trans_ge_wf
.init_asl_gestd_trans_wf
toinit_asl_std_trans_ge_wf
.init_asl_preproc_wf
in greater detail, with an eye toward highlighting the differences betweeninit_asl_preproc_wf
andinit_asl_preproc_wf
.init_asl_preproc_wf
to be as linear as possible.init_asl_preproc_wf
to wrangle multi-echo vs. single-echo data.init_cbfplot_wf
andinit_gecbfplot_wf
.Documentation that should be reviewed