Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor more #264

Merged
merged 24 commits into from
Apr 21, 2023
Merged

Refactor more #264

merged 24 commits into from
Apr 21, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 14, 2023

Closes #265.

Changes proposed in this pull request

  • Rename init_cbf_compt_wf to init_compute_cbf_wf.
  • Rename init_gecbf_compt_wf to init_compute_cbf_ge_wf.
  • Rename init_asl_confs_wf to init_asl_confounds_wf.
  • Rename init_asl_geref_wf to init_asl_reference_ge_wf.
  • Rename init_asl_gereg_wf to init_asl_reg_ge_wf.
  • Rename init_asl_t1_getrans_wf to init_asl_t1_trans_ge_wf.
  • Rename init_asl_gestd_trans_wf to init_asl_std_trans_ge_wf.
    • There are enough similarities between the GE and non-GE versions that I think I can combine them. The GE version needs to skip HMC and SDC, it accepts 4D ASL files instead of split 3D volumes, and it doesn't create a final reference image.
      • Allow HMC and SDC transforms to be "identity" when they're not used. Then we don't need to count the transforms or have "use_hmc" or "use_fieldwarp" parameters.
      • Set hmc_xforms and fieldwarp to identity in GE workflow.
      • Split ASL files for GE workflows.
      • Add flag that will skip the final reference image generation for GE data.
  • Document the steps in init_asl_preproc_wf in greater detail, with an eye toward highlighting the differences between init_asl_preproc_wf and init_asl_preproc_wf.
  • Reorder steps in init_asl_preproc_wf to be as linear as possible.
  • Create a new identity node in init_asl_preproc_wf to wrangle multi-echo vs. single-echo data.
  • Whenever possible, loop over the various CBF connections between workflows, rather than having separate connection assignments. This reduces the amount of code, and only increases the complexity a little bit.
  • Remove unused outputnode from init_cbfplot_wf and init_gecbfplot_wf.

Documentation that should be reviewed

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Apr 14, 2023
@tsalo tsalo merged commit 71fe25d into PennLINC:main Apr 21, 2023
@tsalo tsalo deleted the refactor-more branch April 21, 2023 13:04
@tsalo tsalo mentioned this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASL reference image for GE data may be 4D
1 participant