Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support runs with SCORE/SCRUB disabled #279

Merged
merged 6 commits into from
May 9, 2023
Merged

Support runs with SCORE/SCRUB disabled #279

merged 6 commits into from
May 9, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented May 9, 2023 •
edited
Loading

Closes #278.

Changes proposed in this pull request

  • Fix bug in CBFtsPlot that required SCORE/SCRUB inputs, which wouldn't be available when --scorescrub isn't included in the call.
  • Only connect CBF derivatives that are actually generated across workflows, since asl_std_trans_wf's weird outputnode setup doesn't play well with undefined outputs.
  • Ensure tests cover cases without scorescrub, without basil, and without both.

@tsalo tsalo added the bug Something isn't working label May 9, 2023
@tsalo tsalo merged commit 19f3a20 into PennLINC:main May 9, 2023
@tsalo tsalo deleted the no-scrubs branch May 9, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SCORE/SCRUB disabled
1 participant
@tsalo