Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CombineMotionParameters to support single-volume volume types #316

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 6, 2023

Closes #310. This addresses a bug that will arise when a non-GE dataset is motion corrected, and one or more of the volume types in the ASL file only appear once (e.g., a single M0 scan in the ASL file).

Changes proposed in this pull request

  • Allow mat_files inputs to CombineMotionParameters to be a single file- not just a list of files or None.
    • This is necessary because the MCFLIRT interface returns an OutputMultiPath, which returns a string if the list of outputs has only one element (e.g., if motion correction is run on a single volume). I hate OutputMultiPaths.

This is because the MCFLIRT interface returns an OutputMultiPath, which returns a string if the list of outputs has only one element. I hate this type.
@tsalo tsalo added the bug Something isn't working label Jul 6, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (e4faea1) 62.89% compared to head (ebd91c6) 62.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   62.89%   62.91%   +0.02%     
==========================================
  Files          56       56              
  Lines        5112     5113       +1     
  Branches      706      706              
==========================================
+ Hits         3215     3217       +2     
+ Misses       1650     1648       -2     
- Partials      247      248       +1     
Impacted Files Coverage Δ
aslprep/interfaces/utility.py 88.13% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo merged commit e58fdf6 into PennLINC:main Jul 6, 2023
@tsalo tsalo deleted the motion-correction branch July 6, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASLPrep hangs when changing dseg datatype
2 participants