Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document M0 use in reports #329

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Document M0 use in reports #329

merged 10 commits into from
Oct 4, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 2, 2023

Closes #324.

Changes proposed in this pull request

  • Update workflow descriptions to describe which volume types are used to create reference images (for registration) and calibration images (for CBF calculation).
  • Rename smoothkernel variable to smooth_kernel.
  • Rename processing_target value controllabel to control so I can use it directly in workflow descriptions.
  • Pin aslprep_build to 0.0.2.

@tsalo tsalo marked this pull request as ready for review October 2, 2023 15:57
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Files Coverage Δ
aslprep/workflows/asl/base.py 87.28% <100.00%> (ø)
aslprep/workflows/asl/gecbf.py 92.17% <100.00%> (ø)
aslprep/workflows/asl/util.py 80.76% <ø> (ø)
aslprep/workflows/asl/ge_utils.py 87.23% <55.55%> (-7.51%) ⬇️
aslprep/workflows/asl/cbf.py 71.34% <22.22%> (-1.38%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@tsalo tsalo added the documentation Improvements or additions to documentation label Oct 4, 2023
@tsalo tsalo merged commit 55c378a into PennLINC:main Oct 4, 2023
2 checks passed
@tsalo tsalo deleted the improve-reports branch October 4, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document M0 situation in report
2 participants