Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fMRIPrep-related bugs #366

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Fix fMRIPrep-related bugs #366

merged 2 commits into from
Dec 8, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Dec 8, 2023

Closes none, but addresses ASLPrep's copy of multiple 23.2.0a2-related fMRIPrep bugs.

Changes proposed in this pull request

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (67607e1) 78.81% compared to head (a80e021) 78.73%.
Report is 1 commits behind head on main.

Files Patch % Lines
aslprep/workflows/asl/fit.py 44.44% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   78.81%   78.73%   -0.08%     
==========================================
  Files          39       39              
  Lines        4149     4158       +9     
  Branches      600      602       +2     
==========================================
+ Hits         3270     3274       +4     
- Misses        685      688       +3     
- Partials      194      196       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit 6bcc6ff into PennLINC:main Dec 8, 2023
25 checks passed
@tsalo tsalo deleted the fix-sbref branch December 8, 2023 22:14
@tsalo tsalo added bug Something isn't working nipreps Maintains consistency with the rest of the nipreps ecosystem (especially fMRIPrep). labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nipreps Maintains consistency with the rest of the nipreps ecosystem (especially fMRIPrep).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants