Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use niworkflows enhance-and-skullstrip workflow #371

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Dec 9, 2023

Closes #353.

Changes proposed in this pull request

  • Remove aslprep/workflows/asl/util.py.
  • Replace aslprep.workflows.asl.util.init_enhance_and_skullstrip_asl_wf with niworkflows.func.util.init_enhance_and_skullstrip_bold_wf.

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Dec 9, 2023
@tsalo tsalo changed the title Use niworkflows skullstrip workflow Use niworkflows enhance-and-skullstrip workflow Dec 9, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fc3ec6) 79.02% compared to head (24f4d6e) 78.89%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   79.02%   78.89%   -0.14%     
==========================================
  Files          39       38       -1     
  Lines        4157     4131      -26     
  Branches      602      602              
==========================================
- Hits         3285     3259      -26     
  Misses        676      676              
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo marked this pull request as ready for review December 21, 2023 16:33
@tsalo tsalo merged commit 36c2184 into PennLINC:main Dec 21, 2023
25 checks passed
@tsalo tsalo deleted the use-niworkflows-ref-wf branch December 21, 2023 16:36
@tsalo tsalo added the nipreps Maintains consistency with the rest of the nipreps ecosystem (especially fMRIPrep). label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nipreps Maintains consistency with the rest of the nipreps ecosystem (especially fMRIPrep). refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare ASLPrep and niworkflows skullstrip workflows
2 participants