Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use space definitions from niworkflows #378

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Dec 18, 2023

Closes #352.

Changes proposed in this pull request

  • Pin niworkflows dependency to 1.10.0.
  • Drop ASLPrep spaces module in favor of niworkflows version.

@tsalo tsalo added refactor Changes to the codebase that don't impact workflow inputs or outputs. maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. labels Dec 18, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6c868c) 78.98% compared to head (1f07271) 79.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   78.98%   79.57%   +0.58%     
==========================================
  Files          39       38       -1     
  Lines        4149     3965     -184     
  Branches      602      547      -55     
==========================================
- Hits         3277     3155     -122     
+ Misses        676      632      -44     
+ Partials      196      178      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit a2b41da into PennLINC:main Dec 18, 2023
25 checks passed
@tsalo tsalo deleted the niworkflows-spaces branch December 18, 2023 20:36
@tsalo tsalo added the nipreps Maintains consistency with the rest of the nipreps ecosystem (especially fMRIPrep). label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. nipreps Maintains consistency with the rest of the nipreps ecosystem (especially fMRIPrep). refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use niworkflows' space classes
2 participants