Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add t1tissue term to multi-delay CBF formula #432

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 30, 2024

Closes #431. This should only affect CBF estimates from multi-PLD PCASL data.

Changes proposed in this pull request

  • Add t1tissue terms to exponential terms for multi-delay CBF calculation, to follow Equation 1 in Dai et al. (2012).

@tsalo tsalo added the bug Something isn't working label Jul 30, 2024
@tsalo tsalo merged commit 1703fe2 into PennLINC:main Jul 31, 2024
25 checks passed
@tsalo tsalo deleted the missing-t1tissue branch July 31, 2024 17:50
@lucsanara
Copy link

Dear @tsalo,
Has been this already fixed on v.0.7.2 or do we have to wait for 0.7.3?

@tsalo
Copy link
Member Author

tsalo commented Oct 14, 2024

Sorry, that's my bad. I forgot to make a release after merging this PR. I'll make a release now so 0.7.3 should be available with the change in a couple of hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong equation in utils/cbf.py
2 participants